To CLose or not to Close this is my Question

[vbMarkO]

Ok,

Here my code piece..... DOnt I need to close the file here?

 

If so How?

 

          Try
               If File.Exists(frPath) Then
                   Dim rFile As StreamReader = File.OpenText(frPath)
                   ReadString = rFile.ReadToEnd()
                   stubText.Text = ReadString
               End If
               ' Q:  DO I need to close this File?  How?  Where? Here or after
               '            End Try?
           Catch
           End Try

 

vbMarkO

[penfold69]

Dim rFile as StreamReader
Try
   If File.Exists(frPath) Then
       rFile = File.OpenText(frPath)
       ReadString = rFile.ReadToEnd()
       stubText.Text = ReadString
   End If
Catch ex as Exception
Finally
   rFile.Close()
End Try

[Machaira]

It's always a good practice to close any files you open.

[vbMarkO]

Thanx guys....

 

This one is now resolved your sugestions worked

 

vbMarkO

[jmcilhinney]

Dim rFile as StreamReader
Try
   If File.Exists(frPath) Then
       rFile = File.OpenText(frPath)
       ReadString = rFile.ReadToEnd()
       stubText.Text = ReadString
   End If
Catch ex as Exception
Finally
   rFile.Close()
End Try

This code will throw an NullReferenceException if the file does not exist, because no reference will ever be assigned to the rFile variable but the code will still call Close on it. You would need to test for a null reference in the Finally block:

Dim rFile as StreamReader
Try
   If File.Exists(frPath) Then
       rFile = File.OpenText(frPath)
       ReadString = rFile.ReadToEnd()
       stubText.Text = ReadString
   End If
Catch ex as Exception
Finally
   If Not rFile Is Nothing Then
       rFile.Close()
   End If
End Try

or use two Try...Catch blocks:

Dim rFile as StreamReader
Try
   If File.Exists(frPath) Then
       rFile = File.OpenText(frPath)

       Try
           ReadString = rFile.ReadToEnd()
           stubText.Text = ReadString
       Catch ex as Exception

       Finally
           rFile.Close()
       End Try
   End If
Catch ex as Exception

End Try

[vbMarkO]

Thank you so much :)

 

That did the trick.....