Very basic question about commas..

[Lanc1988]

I have a label with numbers in it (example: 15200) and I would like it to have commas in it since sometimes the number will be quite long.

 

I'm sure this is very simple to do because I had done it once, but I can't find the code for it anymore.

 

Thanks.

[Varghjärta]

Sounds like what I wanted to for an application long time ago. I could never find any ready made code for it (though there probably is something, dealing with formating in some class).

 

Can't you do a loop that inserts a comma into the string at appropiorate places WHILE we're not at the end of the string. And it might be easier code-wise to reverse the string before doing it so one loops form beginning to end so that the commas ends up in the right places(so we don't need to know anything about the number to still insert into the right place), then reverse it again so it's back to normal. Well atleast that's what you could do if you want to have them in groups of three(say: "1284"->"1,284", "1284999"->"1,284,999" etc).

 

If that's something you need lemme know and I'll try to find the code snippet of mine.

[Ralphzehunter]

Hope this helps.

 

Hmm, there is probably a better way to do this, because I made this off the top of my head, but :

 

vbcode:

Dim this As Integer = 1010101777
Dim mystring As String = System.Convert.ToString(this)
For x As Integer = mystring.Length - 3 To 1 Step -3
     mystring = mystring.Insert(x, ",")
Next

 

c++ code:

int this1 = 556654;
System::String ^ mystring;
mystring = System::Convert::ToString(this1);
for(int x = mystring->Length-3; x > 0; x -= 3)
{
   mystring = mystring->Insert(x,",");
}

 

 

This will do the job for you. I was surprised it actually works, but it does.

 

Edit: Oh yeah, you probably know this but the "this" and "this1" are just used as an example, you can use any numbers you want.

 

Sorry I don't know how to do for loops in C# if that's what your using, but you should get the idea.

 

There I go again, making functions for thing that already exist(tostring("N")).

Edited December 6, 2004 by Ralphzehunter

[Joe Mamma]

uses current thread culture

Dim this As Integer = 1010101777
Console.WriteLine(this.ToString("N"));

 

if the culture is en-us

yeilds

1,010,101,777

 

see help: Standard Numeric Format Strings

[Lanc1988]

i have tried a few things trying to use your code Joe Mamma but it won't put the commas...

 

the label that has the number I want commas in is called "lblExpNeeded" (lblExpNeeded.Text)

[Joe Mamma]

I dont know. . . this:

 

 [size=2]
[/size][color=black][size=2]Private[/size][size=2]Sub[/size][size=2] Form1_Load([/size][size=2]ByVal[/size][size=2] sender [/size][size=2]As[/size][size=2]Object[/size][size=2], _[/size][/color]
[color=black][size=2]ByVal[/size][size=2] e [/size][size=2]As[/size][size=2] System.EventArgs) [/size][size=2]Handles[/size][size=2]MyBase[/size][/color][size=2][color=black].Load[/color][/size]
[color=black][size=2]Dim[/size][size=2] i [/size][size=2]As[/size][size=2]Long[/size][/color][size=2][color=black] = 10020020020[/color][/size]
[size=2][color=black]TextBox1.Text = i.ToString("N")[/color][/size]
[color=black][size=2]End[/size][size=2][color=#0000ff][color=black]Sub

[/color][/color][/size][/color]

yields

 

10,020,020,020.00

for me. :confused:

[HJB417]

An alternative is regex, but if I had to choose between regex and jm's solution, I'd go with jm's.

 

string input = "1234567890";
System.Text.StringBuilder output = new System.Text.StringBuilder();
System.Text.RegularExpressions.Match match = System.Text.RegularExpressions.Regex.Match(input, @"^(\d{1,3})(\d{3})*$");
if(match.Success)
{
output.AppendFormat("{0}", match.Groups[1].Captures[0].Value);
foreach(System.Text.RegularExpressions.Capture capture in match.Groups[2].Captures)
	output.AppendFormat(",{0}", capture.Value);
}
//outputs "1,234,567,890"
Console.WriteLine(output);

Edited December 6, 2004 by HJB417

[Iceplug]

This works for me:

 

number.ToString("#,###")

:)

[DiverDan]

How about FormatNumber(123456789)...There are lots of preformated functions with the ability to customize formats in the Format Class. Additionally, these formats take into consideration the user's culture info, ie. commas or spaces for thousands seperators and dots or commas for decimal seperators.