button javascript doesn't stop postback

[Polar Bear]

Hi,

I have a button where I want to do some javascript validation before is runs its OnClick server code. My problem is that even though the javascript function returns false the btnAdd_Click code still gets executed.

Javascript

function confirmAdd()
{
var cmbOrder=document.getElementById("cmbOrder");
var txtInvoiceNumber=document.getElementById("txtInvoiceNumber");
if (cmbOrder.value.length > 0 && txtInvoiceNumber.value.length == 0)
{
exit = confirm("Are you sure that this order has not been invoiced? (OK=Yes Cancel=NO)")
 
if (exit == true)
{
return true; //add order
}
else
{
return false; //dont add order
}
}
else
{
return true; //add order
}
}

HTML code

<asp:Button ID="btnAdd" runat="server" Width="100" Text="Add Order" CausesValidation="True" OnClick="btnAdd_Click" TabIndex="20" />

Page Load

 btnAdd.Attributes.Add("onclick","javascript:confirmAdd();")

 

[HJB417]

what if you do
btnAdd.Attributes.Add("onclick","return confirmAdd()")
or just
btnAdd.Attributes.Add("onclick","confirmAdd()")

 

[Polar Bear]

btnAdd.Attributes.Add("onclick","return confirmAdd();") worked! But you need the semicolor at the end.

Thanks